Repository navigation
Fix flaky bootstrap signal interruption test - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bootstrap interruption fixture can publish its parent-written readiness marker before
sleep 30exists. A process-group SIGTERM in that window misses the new foreground child, so Bash waits for it and the unchanged ten-second harness deadline expires. This failed on main push run 36989150003 after also failing intermittently on PR #2.Replace that marker with an atomic JSON readiness record written by the actual foreground blocking Python child after installing signal handlers. Before signaling, the harness verifies that child's PID is alive in the bootstrap process group. The child blocks directly in
signal.pause(), so readiness cannot precede the blocker.Run 30 interruptions each for SIGINT/SIGTERM/SIGHUP (90 total), assert shell exit codes 130/143/143, temporary cleanup, unchanged fresh/existing pair and launcher contents/metadata, and absence of surviving process-group members. Keep the original ten-second deadline and all other bootstrap assertions.
Validation:
c6f40fb4c9829035c21d1b07dab41e190971cf25, first attempt, all 23 steps successful without skips. Decoded logs confirm all 90 native-root signal cycles, exit codes 130/143/143, maximum exit 0.007s, cleanup/unchanged-pair/no-orphan assertions, 56 Python tests and 241 shell coverage labels.Only
tests/bootstrap.shchanges. Production installer, manager and workflow are byte-identical to main; SCRIPT_VERSION remains 0.1.1 and Telemt remains 3.5.11. Production review found no demonstrated transaction defect; this fixes fixture synchronization. The fixture covers process-group interruption during download, not parent-only signaling or every commit-phase timing.