Repository navigation
feat: auto-detect public IPv4 during interactive install - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interactive installation now suggests a validated public IPv4 from ipify, with icanhazip as a fallback. Enter accepts the suggestion; users can always override it. Detection uses direct IPv4 HTTPS with 2-second connect / 4-second request limits; failed or invalid responses fall back to manual input.
DNS validation, noninteractive options and all other manager operations remain unchanged.
Validation: six mocked prompt/CLI regression tests (RED → PASS), 22 existing dependency/DNS tests, preflight fixtures, Bash syntax, ShellCheck, Python compilation, CI manifest (zero orphan tests), and diff checks passed. No real network requests in the new tests.