refactor: Fix review suggestions

Author: tuxuser

firmware/preloader/src/main.c

@@ -6,6 +6,7 @@
 #define DEBOUNCE_DELAY  200
 #define CLOCK_FREQ_HSI 16000000 // 16 MHz HSI
 
+/* size and crc are being replaced by scripts/fix_size_crc.py */
 __attribute__((section(".tombstone_iapl")))
 __attribute__((used))
 const tombstone_t tombstone = {

firmware/userapp/Core/Inc/button.h

@@ -11,7 +11,6 @@ extern bool button_pressed;
 
 bool Button_IsPressed();
 uint32_t Button_IsPressedDuration();
-void Button_Tick();
 
 #ifdef __cplusplus
 }

firmware/userapp/Core/Src/button.c

@@ -17,8 +17,4 @@ uint32_t Button_IsPressedDuration() {
         }
     }
     return duration_ms;
-}
-
-void Button_Tick() {
-    button_pressed = Button_IsPressed();
 }

firmware/userapp/Core/Src/display.c

@@ -109,7 +109,7 @@ void Display_Init(void)
         tombstone_t *iapl_ts = (tombstone_t *)(TOMBSTONE_OFFSET_IAPL);
         snprintf(lcd_buf, sizeof(lcd_buf), "IAPL %i.%i", iapl_ts->ver_major, iapl_ts->ver_minor);
     } else {
-        strncat(lcd_buf, "IAPL INVALID", sizeof(lcd_buf)-1);
+        snprintf(lcd_buf, sizeof(lcd_buf), "IAPL INVALID");
     }
     u8g2_DrawStr(&myDisplay, 4, 22, lcd_buf);
 
@@ -118,7 +118,7 @@ void Display_Init(void)
         tombstone_t *uapp_ts = (tombstone_t *)(TOMBSTONE_OFFSET_UAPP);
         snprintf(lcd_buf, sizeof(lcd_buf), "UAPP %i.%i", uapp_ts->ver_major, uapp_ts->ver_minor);
     } else {
-        strncat(lcd_buf, "UAPP INVALID", sizeof(lcd_buf)-1);
+        snprintf(lcd_buf, sizeof(lcd_buf), "UAPP INVALID");
     }
     u8g2_DrawStr(&myDisplay, 4, 32, lcd_buf);
     u8g2_SendBuffer(&myDisplay);

firmware/userapp/Core/Src/main.c

@@ -64,6 +64,7 @@ static void MX_CRC_Init(void);
 
 /* Private user code ---------------------------------------------------------*/
 /* USER CODE BEGIN 0 */
+/* size and crc are being replaced by scripts/fix_size_crc.py */
 __attribute__((section(".tombstone_uapp")))
 __attribute__((used))
 const tombstone_t tombstone = {
@@ -116,7 +117,6 @@ int main(void)
   /* USER CODE BEGIN WHILE */
   while (1)
   {
-    Button_Tick();
     Display_Tick();
     /* USER CODE END WHILE */