Add Dreamcast PAC image format, GDPA64BY container format, and fix two bugs - #15
Open
darkstar wants to merge 6 commits into
Open
Add Dreamcast PAC image format, GDPA64BY container format, and fix two bugs#15darkstar wants to merge 6 commits into
darkstar wants to merge 6 commits into
Conversation
Contributor
Author
|
Do you have any repo where I can upload some sample files, for e.g. UnitTests? |
darkstar
changed the title
Owner
|
There's no repo for sample files, although it would be a good idea to have one. I only have some unorganized directories of files locally, almost none of which are immediately useful for ex. unit tests. There's one with around 50 Vita GXT files - most of which in some way used to cause problems with Scarlet, or were otherwise interesting - which might be somewhat useful in this regard. I'll have a closer look at the actual PR later today or over the weekend. |
It's used in the Love Hina games, probably others as well.
This makes converting the worldmap files from Ar Tonelico Qoga work correctly. Maybe the original Data Node detection was not so bad after all ...
This is still not ideal, but at least it does not incorrectly detect *.lzs/*.pac files from Disgaea 3 (PS3) anymore.
...it still lacks an image plugin for the PHYRE format though
Contributor
Author
|
Rebased onto current master and fixed the exception that gets thrown in case of an invalid element index in the GPDA container format. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PAC format is kinda historic, I only know of two games that use it. The (rather simple) GDPA64BY container is (as far as I know) only used in .dat files in the PS3 game Oreimo.
The first fixed bug is related to PSSG files where more complex files would misinterpret data nodes as non-data, which would throw off the reader.
The second bug is related to P5bustupBIN, which incorrectly detects some files from Disgaea3 (PS3) as P5 bin archives. The detection still is not solid (I just kinda assumed that each file is >0 bytes in those containers) but it works a bit better now.
In my opinion, the format detection function should be run with an AND, not with an OR, when combined with the other attributes... I.e. if no FilenamePattern matches, then ignore the file, even if the FormatDetection identifies a positive match. See my recent comment on issue #14 .