Possible fix TID compression flag - #26
Open
shangjiaxuan wants to merge 2 commits into
Open
Conversation
shangjiaxuan
marked this pull request as ready for review
April 20, 2019 02:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compression flag for the format may be wrong. TID files from neptunia v2's GAME0000 GAME00000\event\bg\ has many TID files that has DXT5 compression fourcc, with the bit not set.
The proposed fix is directly check for the compression fourcc. However, a string type is not a char[] as in c/c++. The current fix treats all fourccs with NULL start as non-compressed.
The fix works for Neptunia v2 TID files, but I do not know if it breaks things elsewhere.
(I'm sorry if there's coding style error, etc. I simply do not know much about csharp...)