cancelButtonText 和 confirmButtonText 设置无效 - #171
Open
YQqiang wants to merge 1 commit into
Open
Conversation
…t 设置无效
- (void)setLanguage:(NSString *)language {} 中检查cancelButtonText,confirmButtonText 是否有值
BREAKING CHANGE: PGDatePickManagerHeaderView
|
大佬有没有单独发布新的库啊,这个已经不维护了,无法合并代码 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
分析:
设置
取消确定按钮文案的方法有两处:setLanguage:方法中setupButton方法中setupButton的调用时机为:PGDatePickManagerHeaderView的layoutSubviews时;setLanguage:的调用时机为:PGDatePickManager的viewDidLayoutSubviews时;在
iOS 9.3.2系统下的表现行为是:先调用PGDatePickManagerHeaderView的layoutSubviews,然后调用PGDatePickManager的viewDidLayoutSubviews表现的结果是:
cancelButtonText和confirmButtonText无效修复:
在
setLanguage:中检查cancelButtonText,confirmButtonText 是否有值