fix(runtime): allow dismissing terminated runtime cards - #1115
Merged
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed interactive runtimes left permanent dead cards with only Configure/Restart actions. Add Dismiss for terminated cards, removing the exact runtime ID without starting another interpreter. Live instances are rejected, window scope is checked, and generation counters survive dismissal. Existing WSL worker-stdin deployment fixes are already on main; this PR adds the missing recovery UI.
Closes #1106.
Changes: RuntimeManager::dismiss_dead, one Tauri command, bilingual runtime-card action, runtime documentation, mock bridge and regression tests. No schema changes.
Validation: formatting/diff checks, exact-instance/generation manager test, wasm check and new Playwright dismissal test passed. Full workspace unit/integration tests passed; a doctest build initially hit mixed artifacts from shared worktree build caches, then the full workspace doctest pass succeeded after cleaning generated wisp crate artifacts. Full Playwright: 492 passed, 2 skipped, one unrelated Run-output follow test failed its timing assertion and passed on an isolated rerun.
Manual smoke: on Windows with WSL create a failed Python/R runtime, dismiss it, and confirm the stale record disappears without deployment or restart. The current project's configured slot remains Not started. Ensure live/sibling runtimes and project files remain intact. With an updated build, verify the existing WSL deployment fix succeeds.
Limitations/follow-up: no installer release is performed. v1.8.1 users need a newer build for both fixes. Real WSL deployment remains a platform smoke check.