XWIKI-24806: TextAreaImageUploadIT is flickering and its missing edit-mode cleanup fails the rest of AllIT

[vmassol]

Jira URL

https://jira.xwiki.org/browse/XWIKI-24806

Changes

Description

• Discard the unsaved changes after each test of TextAreaImageUploadIT, so that a test failing in the middle of an edit no longer leaves the page with an armed beforeunload handler.
• Add CKEditor#discardUnsavedChanges() to the CKEditor page objects, marking every editor instance on the current page as clean.

Clarifications

AllIT runs all its @Nested ITs in a single shared browser session, with NestedTextAreaImageUploadIT first. TextAreaImageUploadIT had no @AfterEach, so when one of its tests failed mid-edit the leave confirmation stayed armed and the next navigation died with UnhandledAlertException: Unexpected beforeunload dialog detected (InvalidArgumentException: Unexpected dialog type beforeunload on Chrome). Every remaining nested IT then failed in its setup, so a single flickering test produced six failures — see the two builds of 2026-09-03 linked from the issue, one of which also spent 422 s hung on a single driver.get().

The cleanup needs two steps because two different mechanisms ask for confirmation:

• the comment, the annotation and the in-place property are edited on a view page, where TestUtils#maybeLeaveEditMode() is a no-op (window.XWiki.editor is empty). There the confirmation comes from the CKEditor xwiki-save plugin, whose beforeunload handler tests editor.checkDirty() — hence the new CKEditor#discardUnsavedChanges(), which calls resetDirty() on every instance;
• the object editor asks based on its own form state (dataeditors.js sets window.onbeforeunload from unsavedChanges), which only leaving the edit mode resets — hence the maybeLeaveEditMode() call, done after the editors are marked clean so that leaving doesn't trigger the dialog itself.

This only contains the damage. The underlying flicker — ckeditor.getToolBar().insertImage() occasionally not opening the image dialog within the 10 s wait, seen on master, stable-17.10.x and stable-18.4.x — is still open on XWIKI-24806.

Screenshots & Video

N/A — test-only change, no UI change.

Executed Tests

• mvn clean verify -B -ntp -pl xwiki-platform-core/xwiki-platform-edit/xwiki-platform-edit-test/xwiki-platform-edit-test-docker -Pdocker,integration-tests -Dit.test=AllIT — 17 tests, 0 failures, 0 errors.
• mvn clean install -B -ntp -Plegacy,quality,docker,integration-tests -pl xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test/xwiki-platform-ckeditor-test-pageobjects — 0 Checkstyle violations, Revapi clean.

Expected merging strategy

• Prefers squash: Yes
• Backport on branches:
  • stable-18.4.x
  • stable-17.10.x

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

💚 All backports created successfully

Status	Branch	Result
✅	stable-17.10.x
✅	stable-18.4.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

[github-actions]

💚 All backports created successfully

Status	Branch	Result
✅	stable-17.10.x
✅	stable-18.4.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details