Skip to content

[stable-18.4.x] XWIKI-24806: TextAreaImageUploadIT is flickering and its missing edit-mode cleanup fails the rest of AllIT (#6309) - #6311

Merged
vmassol merged 1 commit into
stable-18.4.xfrom
backport/stable-18.4.x/pr-6309
Sep 4, 2026
Merged

[stable-18.4.x] XWIKI-24806: TextAreaImageUploadIT is flickering and its missing edit-mode cleanup fails the rest of AllIT (#6309)#6311
vmassol merged 1 commit into
stable-18.4.xfrom
backport/stable-18.4.x/pr-6309

Conversation

@github-actions

@github-actions github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Backport

This will backport the following commits from master to stable-18.4.x:

Questions ?

Please refer to the Backport tool documentation

…-mode cleanup fails the rest of AllIT (#6309)

* Discard the unsaved changes after each test, so that a failure no longer leaves an armed
  beforeunload handler that blocks every test running after it in the shared browser session.
* Add CKEditor#discardUnsavedChanges() to the page objects, marking every editor instance on the
  page as clean. This is what arms the leave confirmation for the comment, the annotation and the
  in-place property, all edited on a view page where there is no edit mode to leave.
* Leave the edit mode for the object editor, which asks for confirmation based on its own form state.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
(cherry picked from commit 879250a)
@github-actions
github-actions Bot force-pushed the backport/stable-18.4.x/pr-6309 branch from 92429c2 to a09840d Compare September 4, 2026 10:07
@vmassol
vmassol merged commit 1674aa0 into stable-18.4.x Sep 4, 2026
2 checks passed
@vmassol
vmassol deleted the backport/stable-18.4.x/pr-6309 branch September 4, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant