fix: make edit param required in CommandRegistration interface.

- Reverted the `edit` param in the `handleSingleLineBlock` Configuration method back to be required instead of optional because it otherwise insinuates the method can work without the `edit` param which is not true. It must have the param set to work. Also removed the optional chaining operator on the `edit.insert` call. The TS error that the optional operators fixed will return:

"Type '(textEditor: TextEditor, edit: TextEditorEdit) => void' is not assignable to type '(textEditor: TextEditor, edit?: TextEditorEdit | undefined) => void'.
  Types of parameters 'edit' and 'edit' are incompatible.
    Type 'TextEditorEdit | undefined' is not assignable to type 'TextEditorEdit'.
      Type 'undefined' is not assignable to type 'TextEditorEdit'."

- Fixed the returning TS error above by making the `edit` param required instead of optional in the `handler` function in `CommandRegistration` interface, which the `handleSingleLineBlock` method has to satisfy.

Author: yCodeTech

src/configuration.ts

@@ -939,7 +939,7 @@ export class Configuration {
 	 * @param {vscode.TextEditor} textEditor The text editor.
 	 * @param {vscode.TextEditorEdit} edit The text editor edits.
 	 */
-	private handleSingleLineBlock(textEditor: vscode.TextEditor, edit?: vscode.TextEditorEdit) {
+	private handleSingleLineBlock(textEditor: vscode.TextEditor, edit: vscode.TextEditorEdit) {
 		let langId: LanguageId = textEditor.document.languageId;
 		const singleLineLangs = this.getSingleLineLanguages("supportedLanguages");
 		const customSingleLineLangs = this.getSingleLineLanguages("customSupportedLanguages");
@@ -988,7 +988,7 @@ export class Configuration {
 				indentedNewLine += style + " ";
 			}
 
-			edit?.insert(textEditor.selection.active, indentedNewLine);
+			edit.insert(textEditor.selection.active, indentedNewLine);
 		}
 	}
 

src/interfaces/commands.ts

@@ -18,10 +18,10 @@ export interface CommandRegistration {
 	 * command is executed.
 	 *
 	 * @param textEditor The text editor
-	 * @param edit The text editor edits. Optional because some commands may not need it.
+	 * @param edit The text editor edits.
 	 * @returns void
 	 */
-	handler: (textEditor: vscode.TextEditor, edit?: vscode.TextEditorEdit) => void;
+	handler: (textEditor: vscode.TextEditor, edit: vscode.TextEditorEdit) => void;
 }
 
 /**