chore: drop the circle tables nobody reads

Migration 014 created circle, person_circle, resource_access_rule and
mattermost_circle_link. The circle table has never had an INSERT or a
SELECT anywhere in this repository, and person_circle had one writer:
a copy from itself onto a new person ID, which moved rows nothing put
there. resource_access_rule and mattermost_circle_link are named only by
the migration that made them.

An empty table with a plausible name is worse than no table. Somebody
looked at circle and circle_member today and asked for them to be filled,
which would have changed nothing, because what actually decides a
person's circles is policy.json and the person.circles column projected
from it. Those stay, as does graphiti_namespace.scope_circle_id.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: eastriverlee

internal/store/postgres/person_repository.go

@@ -119,7 +119,7 @@ func (personRepository PersonRepository) canonicalizePersonReferences(legacyPers
 			return errorValue
 		}
 	}
-	return personRepository.canonicalizePersonCircles(legacyPersonID, personID)
+	return nil
 }
 
 func canonicalPersonReferenceUpdateStatements() []canonicalPersonReferenceUpdate {
@@ -145,20 +145,3 @@ func (personRepository PersonRepository) hasTable(tableName string) (bool, error
 	errorValue := row.Scan(&hasTable)
 	return hasTable, errorValue
 }
-
-func (personRepository PersonRepository) canonicalizePersonCircles(legacyPersonID string, personID string) error {
-	_, errorValue := personRepository.database.SQL.ExecContext(context.Background(), `
-INSERT INTO person_circle (person_circle_id, person_id, circle_id, source, created_at, updated_at)
-SELECT $2 || ':' || circle_id, $2, circle_id, source, created_at, updated_at
-FROM person_circle
-WHERE person_id = $1
-ON CONFLICT (person_id, circle_id) DO UPDATE SET
-  source = EXCLUDED.source,
-  updated_at = EXCLUDED.updated_at`, legacyPersonID, personID)
-	if errorValue != nil {
-		return errorValue
-	}
-	_, errorValue = personRepository.database.SQL.ExecContext(context.Background(), `
-DELETE FROM person_circle WHERE person_id = $1`, legacyPersonID)
-	return errorValue
-}

migrations/030_drop_the_circle_tables_nobody_reads.sql

@@ -0,0 +1,4 @@
+DROP TABLE IF EXISTS mattermost_circle_link;
+DROP TABLE IF EXISTS person_circle;
+DROP TABLE IF EXISTS circle;
+DROP TABLE IF EXISTS resource_access_rule;

tests/integration/migrations_apply_test.go

@@ -15,8 +15,8 @@ func TestMigrationsApplyList(t *testing.T) {
 	if errorValue != nil {
 		t.Fatalf("expected migrations to load: %v", errorValue)
 	}
-	if len(migrationPaths) != 29 {
-		t.Fatalf("expected 29 migration files, got %d", len(migrationPaths))
+	if len(migrationPaths) != 30 {
+		t.Fatalf("expected 30 migration files, got %d", len(migrationPaths))
 	}
 }