Use per-user callback files for browser auth handoff - #637
Open
jdpipe wants to merge 2 commits into
Open
Conversation
Prefer XDG_RUNTIME_DIR for GlobalProtect callback port/log files, with user-scoped temp file fallbacks to avoid collisions across sessions.
Probe OpenConnect's generated pkg-config private dependencies so the Rust link step follows the TLS backend selected by OpenConnect configure.
Owner
|
Please remove the unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser-auth callback port and callback log were previously written to fixed filenames under
/tmp. On shared machines, a stale file owned by one user could prevent another user from completing authentication after a crash or restart.Store these files in
XDG_RUNTIME_DIRwhen available, falling back to user-scoped filenames in the system temp directory. This keeps the callback handoff scoped to the interactive user session instead of sharing one global/tmppathname across users.