This repository was archived by the owner on Dec 8, 2022. It is now read-only.
add lesson05 for okhttp extra credit - #50
Open
taobaorun wants to merge 3 commits into
Open
Conversation
yurishkuro
reviewed
Feb 13, 2019
yurishkuro
left a comment
yurishkuro
left a comment
Owner
There was a problem hiding this comment.
Thanks, looks good. A few minor comments.
java/src/main/java/lesson05/README.md is not needed, right?
yurishkuro
reviewed
Feb 20, 2019
| @@ -0,0 +1,23 @@ | |||
| # Lesson 5 - Using Existing Open Source Instrumentation | |||
Owner
There was a problem hiding this comment.
I prefer not to call this 'lesson05'. In all tutorials this is called 'extracredit, and there already exists a package for that, with a readme: https://github.com/yurishkuro/opentracing-tutorial/tree/master/java/src/main/java/extracredit
You can add everything there.
yurishkuro
reviewed
Feb 20, 2019
|
|
||
| @GET | ||
| public String format(@QueryParam("helloStr") String helloStr, @Context HttpHeaders httpHeaders) { | ||
| try (Scope scope = Tracing.startServerSpan(tracer, httpHeaders, "publish")) { |
Owner
There was a problem hiding this comment.
If you really want to implement the fill solution for the extra credit, then this should also use the opentracing-contrib library for Dropwizard. The point of extracredit is to not do instrumentation manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add okhttp extra credit