Support OpenTelemetry SDK - #3559
Closed
AlexanderYastrebov wants to merge 1 commit into
Closed
Conversation
AlexanderYastrebov
added
the
major
szuecs
reviewed
Jul 14, 2025
szuecs
reviewed
Jul 14, 2025
| AccessLogStripQuery bool `yaml:"access-log-strip-query"` | ||
| SuppressRouteUpdateLogs bool `yaml:"suppress-route-update-logs"` | ||
|
|
||
| OpenTelemetry *otel.Options `yaml:"open-telemetry"` |
Member
There was a problem hiding this comment.
Maybe better to tell it's OTelOptions or so
Contributor
Author
There was a problem hiding this comment.
I'd like it to match the flag name which looks ok. Let me think about it and I'll change it later if needed.
Member
There was a problem hiding this comment.
It's just not obvious so maybe change the flag.
It's also kind of new so I would prefer to change it if we have it already.
szuecs
reviewed
Jul 14, 2025
szuecs
reviewed
Jul 14, 2025
Member
|
Would this configure some added span Tags or something like this? |
AlexanderYastrebov
force-pushed
the
add-open-telemetry-2
branch
from
August 7, 2025 09:11
aadd88c to
62fcc1e
Compare
AlexanderYastrebov
force-pushed
the
add-open-telemetry-2
branch
from
September 8, 2025 09:41
62fcc1e to
3cfa267
Compare
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 8, 2025
Add configuration to enable OpenTelemetry tracing instead of OpenTracing. See zalando/skipper#3559 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 8, 2025
Add configuration to enable OpenTelemetry tracing instead of OpenTracing. See zalando/skipper#3559 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 8, 2025
Add configuration to enable OpenTelemetry tracing instead of OpenTracing. See zalando/skipper#3559 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 8, 2025
Add configuration to enable OpenTelemetry tracing instead of OpenTracing. See zalando/skipper#3559 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 8, 2025
Add configuration to enable OpenTelemetry tracing instead of OpenTracing. See zalando/skipper#3559 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 8, 2025
Add configuration to enable OpenTelemetry tracing instead of OpenTracing. See zalando/skipper#3559 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 8, 2025
Add configuration to enable OpenTelemetry tracing instead of OpenTracing. See zalando/skipper#3559 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 8, 2025
Add configuration to enable OpenTelemetry tracing instead of OpenTracing. See zalando/skipper#3559 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 8, 2025
Add configuration to enable OpenTelemetry tracing instead of OpenTracing. See zalando/skipper#3559 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
add-open-telemetry-2
branch
from
September 9, 2025 12:26
df521f9 to
9def5d0
Compare
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 9, 2025
Add configuration to enable OpenTelemetry tracing instead of OpenTracing. See zalando/skipper#3559 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 9, 2025
Add configuration to enable OpenTelemetry tracing instead of OpenTracing. See zalando/skipper#3559 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
When OpenTelemetry is enabled Skipper registers global OpenTelemetry TracerProvider and creates a bridge OpenTracing tracer. This follows recommended migration strategy https://opentelemetry.io/docs/migration/opentracing/#migration-overview OpenTelemetry Init reads configuration options from standard environment variables and allows additional options as a command line flag in yaml format to simplify parsing. Updates #2104 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
add-open-telemetry-2
branch
from
September 9, 2025 15:10
9def5d0 to
3da563a
Compare
AlexanderYastrebov
marked this pull request as ready for review
September 9, 2025 15:11
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 9, 2025
Add configuration to enable OpenTelemetry tracing instead of OpenTracing. See zalando/skipper#3559 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
a4180p
reviewed
Sep 10, 2025
a4180p
reviewed
Sep 10, 2025
a4180p
reviewed
Sep 10, 2025
a4180p
reviewed
Sep 10, 2025
Comment on lines
+1638
to
+1641
| // https://pkg.go.dev/go.opentelemetry.io/otel/bridge/opentracing#readme-interop-from-trace-context-from-opentracing-to-opentelemetry | ||
| if bridgeTracer, ok := p.tracing.tracer.(*otBridge.BridgeTracer); ok { | ||
| ctxWithSpan = bridgeTracer.ContextWithSpanHook(ctxWithSpan, span) | ||
| } |
Member
There was a problem hiding this comment.
hm.. that's interesting.
I don't understand how it works now, when we provide bridgeTracer through skipper options.
Contributor
Author
|
Closing in favour of #3627 which supports environment variable overrides via config. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When OpenTelemetry is enabled Skipper registers global OpenTelemetry TracerProvider and creates a bridge OpenTracing tracer.
This follows recommended migration strategy https://opentelemetry.io/docs/migration/opentracing/#migration-overview
OpenTelemetry Init reads configuration options from standard environment variables and allows additional options as a command line flag in yaml format to simplify parsing.
Updates #2104