more nosuggest testing (#157)

Author: dblodgett-usgs

R/array-nested.R

@@ -190,6 +190,9 @@ NestedArray <- R6::R6Class("NestedArray",
           )
         } else if(is_int64_dtype(self$dtype_obj) && has_bit64()) {
           vec_from_raw <- raw_to_integer64(buf, num_shape_elements, endian)
+        } else if(is_int64_dtype(self$dtype_obj)) {
+          vec_from_raw <- raw_to_double_from_int64(buf, num_shape_elements,
+                                                    endian, dtype_signed)
         } else {
           vec_from_raw <- readBin(
             con = buf,

R/utils.R

@@ -357,6 +357,37 @@ raw_to_integer64 <- function(buf, n, endian = "little") {
   vec
 }
 
+#' Convert raw bytes to double from int64 (fallback when bit64 unavailable)
+#' @param buf Raw vector of 8-byte integers.
+#' @param n Number of elements to read.
+#' @param endian "little" or "big".
+#' @param signed Logical; if TRUE, treat as signed int64.
+#' @return A double vector (precision loss possible for values > 2^53).
+#' @keywords internal
+raw_to_double_from_int64 <- function(buf, n, endian = "little", signed = TRUE) {
+  # Read as signed 4-byte ints (unsigned flag only valid for sizes 1-2)
+  vals <- readBin(con = buf, what = integer(), size = 4, n = n * 2,
+                  signed = TRUE, endian = endian)
+  # vals are interleaved: lo[1], hi[1], lo[2], hi[2], ...
+  idx_lo <- seq(1, n * 2, by = 2)
+  idx_hi <- seq(2, n * 2, by = 2)
+  # Convert to unsigned double: negative int32 means high bit set
+  lo_vals <- ifelse(vals[idx_lo] < 0,
+                    as.double(vals[idx_lo]) + 2^32,
+                    as.double(vals[idx_lo]))
+  hi_vals <- ifelse(vals[idx_hi] < 0,
+                    as.double(vals[idx_hi]) + 2^32,
+                    as.double(vals[idx_hi]))
+  result <- lo_vals + hi_vals * 2^32
+  if (signed) {
+    neg <- hi_vals >= 2^31
+    if (any(neg)) {
+      result[neg] <- result[neg] - 2^64
+    }
+  }
+  result
+}
+
 #' Convert integer64 vector to raw bytes
 #' @param x A bit64::integer64 vector.
 #' @param endian "little" or "big".

tests/testthat/test-01-parallel.R

@@ -3,7 +3,8 @@ library(pizzarr)
 sample_dir <- tools::R_user_dir("pizzarr")
 clean <- !dir.exists(sample_dir)
 
-cache <- pizzarr_sample("dog.ome.zarr")
+cache <- tryCatch(pizzarr_sample("dog.ome.zarr"), error = function(e) NULL)
+has_dog_sample <- !is.null(cache)
 
 SlowGettingDirectoryStore <- R6::R6Class("SlowGettingDirectoryStore",
   inherit = DirectoryStore,
@@ -87,6 +88,7 @@ run_parallel_set <- function(num_workers) {
 }
 
 test_that("can run get_item() and set_item in parallel", {
+  skip_if(!has_dog_sample, "dog.ome.zarr sample not available")
   skip_if_not_installed("bench")
 
   bench_df <- bench::mark(
@@ -108,6 +110,7 @@ test_that("can run get_item() and set_item in parallel", {
 })
 
 test_that("can run set_item() in parallel", {
+  skip_if(!has_dog_sample, "dog.ome.zarr sample not available")
   skip_if_not_installed("bench")
 
   bench_df <- bench::mark(

tests/testthat/test-utils.R

@@ -4,7 +4,8 @@ sample_dir <- tools::R_user_dir("pizzarr")
 clean <- !dir.exists(sample_dir)
 
 test_that("demo data", {
-  
+  skip_if_not_installed("crul")
+
   demo_data <- pizzarr_sample()
 
   expect_true(all(dir.exists(demo_data)))