Repository navigation
Conversation
zarr-python and xarray write V3 consolidated metadata inside the root zarr.json rather than a .zmetadata key, so V3 groups over HTTP opened with no members
Consolidated metadata lists metadata files only, so contains_item() reported every chunk key as missing on any consolidated store
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target branch:
developSummary
I was testing this library and found it was unable to read the consolidated metadata from zarr v3 written by xarray which place it inside zarr.json instead of .zmetadata where this function looks.
This isn't in the core zarr v3 spec, but it is implemented by zarr-python and xarray by default, so I thought I would submit a PR to see if you are interested.
Alongside this, I found a related issue where
contains_itemreturns FALSE for any chunk key on a consolidated store, since the index only lists metadata files:I've kept these as 2 separate commits.
All of the changes are in
R/stores.R+ the added tests.The main changes:
/instead of keys starting with a.The old filter removed .zgroup but would have listed the root zarr.json as a memberTest plan