Repository navigation
feat: align Zarr array metadata class names - #4527
Open
victorwon2001 wants to merge 1 commit into
Open
victorwon2001 wants to merge 1 commit into
victorwon2001 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4527 +/- ##
==========================================
+ Coverage 94.71% 94.73% +0.01%
==========================================
Files 94 94
Lines 13663 13665 +2
==========================================
+ Hits 12941 12945 +4
+ Misses 722 720 -2
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename the concrete Zarr array metadata dataclasses to
ArrayMetadataV2andArrayMetadataV3, while keepingArrayV2MetadataandArrayV3Metadataas aliases to the same classes. Both spellings are available from their versioned modules andzarr.core.metadata; theArrayMetadataunion uses the canonical names without changing metadata serialization, equality or array behavior.For reviewers
Existing imports,
isinstancechecks, class patterns and historical pickle class references continue to resolve through the aliases, but reflection such as__name__now reports the new canonical names. Focused and broader metadata/array/group regressions, strict typing, scoped hooks, changelog validation and documentation checks passed; a PR-numbered feature changelog and human attestation remain publication steps.Author attestation
TODO
docs/user-guide/*.mdchanges/Fixes #3843