[krist7599555]

Summary

• Fixes loadAfterMutationEntities builds invalid WHERE (id) IN () for a zero-match updateMany/deleteMany when any afterEntityMutation hook is registered (MySQL) #2884: loadAfterMutationEntities treated an empty preUpdateIds/mutatedIds array as truthy, so a zero-match update/updateMany on MySQL (no RETURNING support) built WHERE (id) IN () once any plugin registered an afterEntityMutation hook — invalid SQL, thrown app-wide for every zero-match write, not just the hooked model.
• Adds an explicit zero-length branch that returns [] directly, distinct from the existing undefined ("can't determine ids at all") branch which still warns.

Test plan

• New regression test tests/regression/test/issue-2886.test.ts: fails against dev HEAD with the exact ER_PARSE_ERROR from the issue, passes with this fix.
• tests/e2e/orm/plugin-infra/entity-mutation-hooks.test.ts (35 tests) still green against MySQL with the fix applied.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Fixed an issue where bulk updates for records that do not exist could trigger an unnecessary reload attempt on some databases. These updates now complete successfully and report zero affected records. This keeps the result consistent when no records match, without changing how updates behave when matching records are found.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: zenstackhq/zenstack
• Branch: dev
• File: .coderabbit.yaml
• Commit: 151524b
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: b3a36041-fdce-4f48-87c9-d74063abde64

📥 Commits

Reviewing files that changed from the base of the PR and between 3a928bd and 2f5978f.

📒 Files selected for processing: 1

• tests/regression/test/issue-2884.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

📝 Walkthrough

When a dialect does not support RETURNING and a mutation has no determined IDs, the executor now returns an empty entity list without reloading entities or issuing the warning for undetermined IDs. A MySQL regression test covers a zero-match updateMany with an after-mutation hook.

Changes: MySQL zero-match mutations

Layer / File(s)	Summary
Empty ID handling and regression coverage packages/orm/src/client/executor/zenstack-query-executor.ts, tests/regression/test/issue-2884.test.ts	The executor returns an empty list when the determined ID list is empty. The MySQL regression test checks that a zero-match updateMany with a no-op after-mutation hook resolves with a count of zero.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Possibly related issues

• MySQL: zero-match update/updateMany throws SQL syntax error when an afterEntityMutation hook is registered #2886 — Describes the zero-match MySQL update failure addressed by the empty-ID handling change.

Merge Risk: ⚪ Minimal · up to 2f597

The reviewed change has no supported merge-blocking risk.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: preventing an empty IN() clause when MySQL updates match zero rows.
Linked Issues check		Issue #2884 requires zero-match MySQL mutations with an afterEntityMutation hook to complete without an empty IN clause. The change returns [] when the determined ID list is empty. It preserves …
Out of Scope Changes check		The changes are limited to the executor branch for empty mutation ID lists and a regression test for issue #2884. These changes directly support the linked issue. No unrelated change is shown.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…

Full details: Linked Issues check

Explanation

Issue #2884 requires zero-match MySQL mutations with an afterEntityMutation hook to complete without an empty IN clause. The change returns [] when the determined ID list is empty. It preserves the warning path for undetermined IDs. The regression test verifies zero-match updateMany returns { count: 0 }. The existing delete path returns before after-entity reload, so it does not build an empty IN clause.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}