docs: fix non-working cargo install instructions - #2
Merged
Conversation
`cargo install zentinel-agent-js` fails: the crate is not published on crates.io. Documents `cargo install --git`, which does work, plus the prebuilt release binaries. Also points the bundle docs link at docs.zentinelproxy.io; the zentinelproxy.io/docs/ URL 404s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo install zentinel-agent-jsdoes not work — the crate is not published on crates.io (reported for the bot-management agent in zentinelproxy/zentinel-agent-bot-management#2; all 25 agent repos carried the same instruction).This repo depends on
zentinel-agent-protocolfrom crates.io, socargo install --git https://github.com/zentinelproxy/zentinel-agent-jsdoes work — I verified this end to end on a sibling agent repo (clean build, binary installed). The README now documents that plus the prebuilt release binaries.Release-asset names were read from the actual latest release rather than assumed (
v0.3.0, mode: standard).Also fixes the bundle docs link:
zentinelproxy.io/docs/…404s; the docs are served atdocs.zentinelproxy.io/….