fix: dev mode for bundle compilation and OTP 28 tar compat

- Add skip_validation config to Compiler so dev works without the
  sentinel CLI binary (auto-enabled when SENTINEL_BINARY is unset)
- Add local filesystem storage backend to avoid requiring MinIO/S3
  in development
- Fix erl_tar.create call for OTP 28 which removed in-memory binary
  support from create/2
- Fix drift_events migration ordering (rename to run after table
  creation)

Author: raffaelschneider

.gitignore

@@ -39,3 +39,6 @@ npm-debug.log
 *.db
 *.db-shm
 *.db-wal
+
+# Local bundle storage (dev)
+/priv/bundles/

config/dev.exs

@@ -88,18 +88,12 @@ config :phoenix_live_view,
 # Disable swoosh api client as it is only required for production adapters.
 config :swoosh, :api_client, false
 
-# Bundle storage (MinIO in development)
+# Bundle storage (local filesystem in development, MinIO/S3 in production)
 config :sentinel_cp, SentinelCp.Bundles.Storage,
-  bucket: "sentinel-bundles",
-  ex_aws_config: [
-    access_key_id: "minioadmin",
-    secret_access_key: "minioadmin",
-    scheme: "http://",
-    host: "localhost",
-    port: 9000,
-    region: "us-east-1"
-  ]
+  backend: :local,
+  local_dir: Path.expand("../priv/bundles", __DIR__)
 
-# Bundle compiler
+# Bundle compiler (skip validation in dev — sentinel binary not required)
 config :sentinel_cp, SentinelCp.Bundles.Compiler,
-  sentinel_binary: System.get_env("SENTINEL_BINARY", "sentinel")
+  sentinel_binary: System.get_env("SENTINEL_BINARY", "sentinel"),
+  skip_validation: !System.get_env("SENTINEL_BINARY")

lib/sentinel_cp/bundles/compiler.ex

@@ -13,19 +13,24 @@ defmodule SentinelCp.Bundles.Compiler do
   Returns {:ok, output} or {:error, output}.
   """
   def validate(config_source) when is_binary(config_source) do
-    with {:ok, tmpfile} <- write_temp_config(config_source) do
-      try do
-        case System.cmd(sentinel_binary(), ["validate", "--config", tmpfile],
-               stderr_to_stdout: true
-             ) do
-          {output, 0} -> {:ok, output}
-          {output, _code} -> {:error, output}
+    if skip_validation?() do
+      Logger.info("Skipping sentinel validation (dev mode)")
+      {:ok, "Validation skipped (dev mode)"}
+    else
+      with {:ok, tmpfile} <- write_temp_config(config_source) do
+        try do
+          case System.cmd(sentinel_binary(), ["validate", "--config", tmpfile],
+                 stderr_to_stdout: true
+               ) do
+            {output, 0} -> {:ok, output}
+            {output, _code} -> {:error, output}
+          end
+        rescue
+          e in ErlangError ->
+            {:error, "Failed to run sentinel binary: #{inspect(e)}"}
+        after
+          File.rm(tmpfile)
         end
-      rescue
-        e in ErlangError ->
-          {:error, "Failed to run sentinel binary: #{inspect(e)}"}
-      after
-        File.rm(tmpfile)
       end
     end
   end
@@ -111,16 +116,20 @@ defmodule SentinelCp.Bundles.Compiler do
   end
 
   defp create_tar(dir, files) do
-    # Use Erlang's :erl_tar for portability
-    {:ok, tar_data} =
-      files
-      |> Enum.map(fn file ->
+    # Use Erlang's :erl_tar — write to temp file then read back
+    # (OTP 28 removed in-memory binary support from create/2)
+    tmptar = Path.join(System.tmp_dir!(), "bundle-tar-#{System.unique_integer([:positive])}.tar")
+
+    file_entries =
+      Enum.map(files, fn file ->
         path = Path.join(dir, file)
         content = File.read!(path)
         {String.to_charlist(file), content}
       end)
-      |> :erl_tar.create({:binary, []})
 
+    :ok = :erl_tar.create(String.to_charlist(tmptar), file_entries)
+    tar_data = File.read!(tmptar)
+    File.rm!(tmptar)
     tar_data
   end
 
@@ -143,7 +152,16 @@ defmodule SentinelCp.Bundles.Compiler do
   end
 
   defp sentinel_binary do
-    Application.get_env(:sentinel_cp, __MODULE__, [])
+    compiler_config()
     |> Keyword.get(:sentinel_binary, "sentinel")
   end
+
+  defp skip_validation? do
+    compiler_config()
+    |> Keyword.get(:skip_validation, false)
+  end
+
+  defp compiler_config do
+    Application.get_env(:sentinel_cp, __MODULE__, [])
+  end
 end

lib/sentinel_cp/bundles/storage.ex

@@ -7,47 +7,62 @@ defmodule SentinelCp.Bundles.Storage do
   Uploads data to the configured bucket.
   """
   def upload(key, data) when is_binary(data) do
-    bucket()
-    |> ExAws.S3.put_object(key, data, content_type: "application/gzip")
-    |> ExAws.request(ex_aws_config())
-    |> case do
-      {:ok, _} -> :ok
-      {:error, reason} -> {:error, {:upload_failed, reason}}
+    if local_storage?() do
+      local_upload(key, data)
+    else
+      bucket()
+      |> ExAws.S3.put_object(key, data, content_type: "application/gzip")
+      |> ExAws.request(ex_aws_config())
+      |> case do
+        {:ok, _} -> :ok
+        {:error, reason} -> {:error, {:upload_failed, reason}}
+      end
     end
   end
 
   @doc """
   Downloads data from the configured bucket.
   """
   def download(key) do
-    bucket()
-    |> ExAws.S3.get_object(key)
-    |> ExAws.request(ex_aws_config())
-    |> case do
-      {:ok, %{body: body}} -> {:ok, body}
-      {:error, reason} -> {:error, {:download_failed, reason}}
+    if local_storage?() do
+      local_download(key)
+    else
+      bucket()
+      |> ExAws.S3.get_object(key)
+      |> ExAws.request(ex_aws_config())
+      |> case do
+        {:ok, %{body: body}} -> {:ok, body}
+        {:error, reason} -> {:error, {:download_failed, reason}}
+      end
     end
   end
 
   @doc """
   Generates a presigned URL for downloading a bundle.
   """
   def presigned_url(key, expires_in \\ 3600) do
-    config = ex_aws_config()
-
-    ExAws.S3.presigned_url(config, :get, bucket(), key, expires_in: expires_in)
+    if local_storage?() do
+      {:ok, "/local-storage/#{key}"}
+    else
+      config = ex_aws_config()
+      ExAws.S3.presigned_url(config, :get, bucket(), key, expires_in: expires_in)
+    end
   end
 
   @doc """
   Deletes an object from the configured bucket.
   """
   def delete(key) do
-    bucket()
-    |> ExAws.S3.delete_object(key)
-    |> ExAws.request(ex_aws_config())
-    |> case do
-      {:ok, _} -> :ok
-      {:error, reason} -> {:error, {:delete_failed, reason}}
+    if local_storage?() do
+      local_delete(key)
+    else
+      bucket()
+      |> ExAws.S3.delete_object(key)
+      |> ExAws.request(ex_aws_config())
+      |> case do
+        {:ok, _} -> :ok
+        {:error, reason} -> {:error, {:delete_failed, reason}}
+      end
     end
   end
 
@@ -59,12 +74,48 @@ defmodule SentinelCp.Bundles.Storage do
   end
 
   defp bucket do
-    Application.get_env(:sentinel_cp, __MODULE__, [])
+    storage_config()
     |> Keyword.get(:bucket, "sentinel-bundles")
   end
 
   defp ex_aws_config do
-    Application.get_env(:sentinel_cp, __MODULE__, [])
+    storage_config()
     |> Keyword.get(:ex_aws_config, [])
   end
+
+  defp local_storage? do
+    storage_config()
+    |> Keyword.get(:backend, :s3) == :local
+  end
+
+  defp local_storage_dir do
+    storage_config()
+    |> Keyword.get(:local_dir, Path.expand("priv/bundles"))
+  end
+
+  defp storage_config do
+    Application.get_env(:sentinel_cp, __MODULE__, [])
+  end
+
+  defp local_upload(key, data) do
+    path = Path.join(local_storage_dir(), key)
+    File.mkdir_p!(Path.dirname(path))
+    File.write!(path, data)
+    :ok
+  end
+
+  defp local_download(key) do
+    path = Path.join(local_storage_dir(), key)
+
+    case File.read(path) do
+      {:ok, data} -> {:ok, data}
+      {:error, reason} -> {:error, {:download_failed, reason}}
+    end
+  end
+
+  defp local_delete(key) do
+    path = Path.join(local_storage_dir(), key)
+    File.rm(path)
+    :ok
+  end
 end