Repository navigation
Public access to zhmcclient.Session password - #2305
Merged
Merged
Conversation
andy-maier
force-pushed
the
andy/testutils-hmc-auth
branch
from
October 15, 2026 11:56
f20fc44 to
38d43a6
Compare
Collaborator
|
coverage: 79.833% (+0.02%) from 79.814% — andy/testutils-hmc-auth into master |
andy-maier
force-pushed
the
andy/testutils-hmc-auth
branch
2 times, most recently
from
October 15, 2026 12:19
b6cbe9c to
92306fb
Compare
Note that there are legitimate reasons to get the session password in a Python program, including the zhmcclient package itself. Details: * Changed the protected '_password' attribute in the 'zhmcclient.Session' class to be available via a new public 'password' attribute, which is gettable and settable. * Access via the protected attribute '_password' is still possible, but that attribute has been deprecated and getting or setting it now causes an according Python DeprecationWarning to be issued. * Adjusted the naming rules in the pylint config file to allow for names that begin with two underscores. This was needed to support the internal '__password' attribute. Signed-off-by: Andreas Maier <maiera@de.ibm.com>
andy-maier
force-pushed
the
andy/testutils-hmc-auth
branch
from
October 15, 2026 12:36
92306fb to
76967ab
Compare
nandhinim24
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For details, see the commit message.
Unit testcases have been added.