Repository navigation
feat(introspection): return structured failure details - #576
shreemaan-abhishek wants to merge 2 commits into
Conversation
|
@kevinlzw could you please review this PR? |
|
Thanks for the PR. I reviewed the diff and have two non-blocking suggestions:
I haven't rerun the tests locally; this review is based on the code and test changes, with CI passing. Also, I'll be on vacation for about two weeks, so my replies may be slower during that time. Thanks for your patience! |
|
Thanks, both suggestions are addressed in eca4a7f. |
|
Enjoy your vacation, thanks a lot! |
kevinlzw
left a comment
There was a problem hiding this comment.
Thanks for addressing both suggestions. The negative-cache and coalesced-failure tests now cover the additional return values, and the ChangeLog documents the stricter boolean active validation. Reviewed eca4a7f; CI is passing. I have not rerun the tests locally. Looks good to me.
|
thank you, if you can, please let us know when will the next release be conducted? |
Summary
introspectwith an additive raw endpoint status and structured failure result while preserving its existing first two return valuesFixes #574
Checklist
docker build -f tests/Dockerfile . -t lua-resty-openidc/testdocker run -t --rm lua-resty-openidc/test:latestChangeLogis updated for behavior changes, bug fixes, features, or user-visible documentation changes