Check OpenURL DC metadata for possible book type. - #42
Open
andjsmit wants to merge 2 commits into
Open
Conversation
Author
|
Could a contributor please take look at this PR to see if it might be feasible? |
Author
|
@dstillman Could I ask for a review this PR? I notice you are the most recent committer to this repo. Our library catalog ( IU Cat ) would benefit greatly if this or a better solution was implemented for help identify ebooks as books versus websites. I'd appreciate any feedback you might provide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have noticed Zotero is saving eBooks as webpages instead of books from our catalog (https://iucat.iu.edu). Currently, code is setting all OpenURLs using DC metadata format as type webpage. This PR attempts to make exceptions to this rule for items that are in fact books.
In our case, ebooks are returning
rft.format=e_book, so was added to list of exceptions.