Fix attachment cookie handling with Firefox First-Party Isolation - #635
Closed
pellaeon wants to merge 1 commit into
Closed
Fix attachment cookie handling with Firefox First-Party Isolation#635pellaeon wants to merge 1 commit into
pellaeon wants to merge 1 commit into
Conversation
Resolve cookies using the originating tab’s Firefox FPI and container context, and avoid combining cookies from unrelated partitions. Gracefully continue attachment downloads when cookie enumeration fails, scope temporary Cookie headers to the exact request URL, and preserve browser cookie semantics when injecting contextual cookies. Also retain compatibility with older Chromium versions that reject partitionKey and preserve the tab context during bot-bypass retries.
Member
|
Could you provide URLs, procedures and software versions with which you manually tested this and confirmed it works? |
Author
Before fix behavior:
After fix behavior: |
Member
|
Thanks for the PR. This wasn't quite in the state that we'd be able to merge, but I used it as a starting point for a smaller change. It's now available in the Zotero Connector Beta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Resolve cookies using the originating tab’s Firefox FPI and container context, and avoid combining cookies from unrelated partitions.
Gracefully continue attachment downloads when cookie enumeration fails, scope temporary Cookie headers to the exact request URL, and preserve browser cookie semantics when injecting contextual cookies.
Also retain compatibility with older Chromium versions that reject partitionKey and preserve the tab context during bot-bypass retries.
Fixes #226
The code changes are proposed by a LLM and manually reviewed by me line-by-line. Manual testing shows that this PR fixes PDF saving issues on Firefox with FPI enabled.