fix: support @cloudflare/workers-types v5 (widen peer to >=4) - #59
Merged
Conversation
mmcintosh
marked this pull request as ready for review
July 22, 2026 00:24
commit: |
Owner
|
@mmcintosh - hey there.. thanks for the contribution! Please remove the excess doc changes, we would just need the package.json 1 line change |
mmcintosh
force-pushed
the
fix/workers-types-v5-peer
branch
from
July 22, 2026 16:08
fc8afde to
4d2953c
Compare
mmcintosh
changed the title
Contributor
Author
|
Done — slimmed to the one-line package.json change; README and workflow additions removed. Thanks for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Widens the
@cloudflare/workers-typespeerDependency from^4.0.0to>=4so the library installs cleanly for consumers on currentwrangler(4.108+ peersworkers-types@5, which the old pin made unresolvable). Closes #58.Validation
Clean clone (pnpm 10.10.0 / Node 20), mirroring what
build.ymlchecks:4.20260405.1)5.20260721.1)pnpm buildpnpm typecheckv5's only breaking change is the removal of dated entrypoints, which this library never imported — it consumes only stable type-only binding types (
D1Database,KVNamespace,R2Bucket,IncomingRequestCfProperties). Fully backward-compatible: v4 remains supported,>=4only adds v5.Root cause + reproduction in #58.