Skip to content

Commit 8014ef2

Browse files
committed
make fragments' Test.fromData be generated by relay compiler
this allows to not export the `Fragment` from a relay component to keep fast refresh this implementation also makes it typesafe
1 parent 049414f commit 8014ef2

56 files changed

Lines changed: 276 additions & 14 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# master
2+
3+
- generate fragments' `Test.fromData` inside `[FragmentName]_graphql.res` to avoid exporting the fragment module from the relay component. https://github.com/zth/rescript-relay/pull/635
4+
15
# 4.5.1
26

37
- Fix `traverse` exiting after a custom-scalar field (single array-backed `c`, or `ca`), leaving subsequent fields on the same parent uncoerced. Surfaced as raw `null` for nullable response fields, raw ReScript values for unserialized variables, and (in nested input objects) silently skipped converters. Closes #582; extends #434's #407 fix so trailing fields are preserved.

packages/relay

Submodule relay updated 57 files

packages/rescript-relay/__tests__/Test_testingHelpers.res

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,11 @@ module Interleaved = {
9494

9595
<div>
9696
<Synthetic
97-
user={Fragment.Test.fromData({
97+
user={TestTestingHelpers_user_graphql.Test.fromData({
9898
__id: RescriptRelay.makeDataId("interleaved-synthetic-user"),
9999
firstName: "Interleaved Synthetic",
100100
onlineStatus: Some(Online),
101-
fragmentRefs: SubFragment.Test.fromData({lastName: "User"}),
101+
fragmentRefs: TestTestingHelpers_sub_user_graphql.Test.fromData({lastName: "User"}),
102102
})}
103103
/>
104104
<Synthetic user=data.loggedInUser.fragmentRefs />
@@ -109,35 +109,36 @@ module Interleaved = {
109109
@live
110110
let synthetic = () =>
111111
<Synthetic
112-
user={Fragment.Test.fromData({
112+
user={TestTestingHelpers_user_graphql.Test.fromData({
113113
__id: RescriptRelay.makeDataId("synthetic-user-1"),
114114
firstName: "Synthetic",
115115
onlineStatus: Some(Online),
116-
fragmentRefs: SubFragment.Test.fromData({lastName: "User"}),
116+
fragmentRefs: TestTestingHelpers_sub_user_graphql.Test.fromData({lastName: "User"}),
117117
})}
118118
/>
119119

120120
@live
121121
let syntheticOpt = () =>
122122
<SyntheticOpt
123-
user={Fragment.Test.fromData({
123+
user={TestTestingHelpers_user_graphql.Test.fromData({
124124
__id: RescriptRelay.makeDataId("synthetic-user-2"),
125125
firstName: "Synthetic",
126126
onlineStatus: Some(Online),
127-
fragmentRefs: SubFragment.Test.fromData({lastName: "User"}),
127+
fragmentRefs: TestTestingHelpers_sub_user_graphql.Test.fromData({lastName: "User"}),
128128
})}
129129
/>
130130

131131
@live
132132
let syntheticPlural = () =>
133133
<SyntheticPlural
134-
users={PluralFragment.Test.fromData([
134+
users={TestTestingHelpers_plural_user_graphql.Test.fromData([
135135
{id: "synthetic-user-3", firstName: "Plural Synthetic", onlineStatus: Some(Online)},
136136
])}
137137
/>
138138

139139
@live
140-
let syntheticEmptyPlural = () => <SyntheticPlural users={PluralFragment.Test.fromData([])} />
140+
let syntheticEmptyPlural = () =>
141+
<SyntheticPlural users={TestTestingHelpers_plural_user_graphql.Test.fromData([])} />
141142

142143
@live
143144
let environment = () => RescriptRelay_Test.createMockEnvironment()

packages/rescript-relay/__tests__/__generated__/GroupAvatar_group_graphql.res

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/rescript-relay/__tests__/__generated__/HasNameComponent_hasName_graphql.res

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/rescript-relay/__tests__/__generated__/LocalUser____relay_model_instance_graphql.res

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/rescript-relay/__tests__/__generated__/LocalUser__id_graphql.res

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/rescript-relay/__tests__/__generated__/RichContent_content_graphql.res

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/rescript-relay/__tests__/__generated__/TestAliasedFragments_userFirstName_graphql.res

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/rescript-relay/__tests__/__generated__/TestAliasedFragments_userLastName_graphql.res

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)