Fix native browser ESM loading - #122
Merged
Merged
Conversation
Owner
Author
|
@tukkek lmk your thoughts |
This was referenced Aug 26, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index.mjsa self-contained native ES module that works in browsers and URL-based module loadersremove-markdown/index.mjssubpath with matching ESM declarationsProblem
The
0.7.0-rc.0ESM entry imported its default export fromindex.js. Package-aware Node and Deno npm resolution treated that file as CommonJS and worked, but native browser and remote URL loaders parsed it as ESM and failed with:This follow-up to #119 removes that dependency from the portable ESM entry while retaining the established CommonJS behavior and Node interop.
Compatibility design
index.jsremains the canonical, unchanged CommonJS implementation.index.mjsis generated as a self-contained ESM implementation.index.node.mjsremains a thin CommonJS interop wrapper for normal Node package imports.index.mjs; Node selectsindex.node.mjs.prepublishOnlyand the module test suite.Validation
index.mjsimport0.6.4Rollout
0.7.0-rc.0is already published and immutable. After this merges, the next prerelease should be published as0.7.0-rc.1under thenextdist-tag and receive a short browser-focused soak before promotion.Performance issue #118 remains separate.