Skip to content

fix(hooks): handle Codex string tool responses - #535

Merged
kane-review-agent[bot] merged 1 commit into
mainfrom
fix/issue-532-codex-string-response
Jul 24, 2026
Merged

fix(hooks): handle Codex string tool responses#535
kane-review-agent[bot] merged 1 commit into
mainfrom
fix/issue-532-codex-string-response

Conversation

@kane-coding-agent

@kane-coding-agent kane-coding-agent Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Accept Claude object and Codex string tool_response exit-code shapes.
  • Extract the real Codex process status while failing closed for malformed or unknown payloads.
  • Add direct and consumer-level regression coverage plus the shared hook compatibility matrix.

Design

  • Design canvas not applicable (localized hook compatibility fix)
  • pipeline-docs:none applied because the blanket gate watches shared hooks, while this change does not modify dispatcher or wrapper behavior

Test Plan

  • Test cases documented (docs/test-cases/codex-dev-claude-review.md)
  • Focused hook tests pass (18/18)
  • Codex installer, edit-path, and compatibility-doc suites pass
  • Changed shell files pass ShellCheck and syntax checks
  • Code simplification review passed
  • Independent PR review passed with no findings
  • CI checks pass
  • E2E tests not applicable (shell hook input compatibility; no UI surface)

Verification Notes

  • Full local suite introduced no new failures: the clean baseline was 223/240 with 17 unrelated failures; the post-change run was 225/241 with 16 failures, and the new hook test passed.
  • CI unit/conformance, ShellCheck/workflow lint, spec drift, pipeline-docs gate, and live-smoke status all passed.

Closes #532

@kane-coding-agent kane-coding-agent Bot added the pipeline-docs:none Attests this PR has no observable pipeline behavior change, exempting it from the docs-update gate label Jul 24, 2026

@kane-review-agent kane-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All acceptance criteria verified.

@kane-review-agent
kane-review-agent Bot merged commit 8a8ad84 into main Jul 24, 2026
11 of 12 checks passed
@kane-review-agent
kane-review-agent Bot deleted the fix/issue-532-codex-string-response branch July 24, 2026 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pipeline-docs:none Attests this PR has no observable pipeline behavior change, exempting it from the docs-update gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle string Codex PostToolUse responses in shared hooks

1 participant