Skip to content

fix: add retention-days to security scan artifacts - #64

Merged
zxkane merged 1 commit into
mainfrom
fix/artifact-retention
Mar 13, 2026
Merged

fix: add retention-days to security scan artifacts#64
zxkane merged 1 commit into
mainfrom
fix/artifact-retention

Conversation

@zxkane

@zxkane zxkane commented Mar 13, 2026

Copy link
Copy Markdown
Owner

Problem

GitHub Actions storage quota exceeded (0.5 GB used / 0.5 GB included). The security-scan workflow was uploading artifacts without retention-days, defaulting to 90 days. This resulted in 912 accumulated artifacts.

Fix

  • Added retention-days: 3 to both security-reports and security-summary artifact uploads
  • 3 days is sufficient for reviewing security findings before they expire

Impact

  • Prevents future storage quota exhaustion
  • Old security artifacts will auto-expire after 3 days instead of 90

Reduce artifact retention from default 90 days to 3 days for
security-reports and security-summary artifacts. This prevents
GitHub Actions storage quota from being exceeded.

912 artifacts were accumulating in storage due to missing retention config.

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes correctly address the GitHub Actions storage quota issue by adding retention-days: 3 to both artifact uploads. The implementation is syntactically correct, properly indented, and follows GitHub Actions best practices. The 3-day retention period is appropriate for temporary security reports. No issues found that would block merge.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@github-actions

Copy link
Copy Markdown
Contributor

πŸ”’ Security Scan Results

Status: 🟑 HIGH ISSUES - Review required!

Summary

  • Critical Issues: 0
  • High Issues: 0
  • Medium Issues: 0
  • Low Issues: 0

NPM Vulnerabilities

  • Critical: 0
  • High: 2

Security Score: N/A/10

Please run ./security-check.sh locally for detailed findings.

πŸ“‹ View detailed reports

@zxkane
zxkane merged commit 2f21450 into main Mar 13, 2026
5 checks passed
@zxkane
zxkane deleted the fix/artifact-retention branch March 13, 2026 01:30
@zxkane zxkane mentioned this pull request Apr 9, 2026
3 tasks
zxkane added a commit that referenced this pull request Apr 9, 2026
## Summary

- Bump version from 1.2.0 to 1.3.0
- Update CHANGELOG.md with all changes since v1.2.0

### Changes in this release

#### Changed
- **Upgrade OpenHands from v1.4.0 to v1.6.0** (#65) β€” 341 upstream
commits, SDK v1.15.0, removed custom S3EventService in favor of upstream
AwsEventService
- **Replace github-workflow skill with autonomous-dev-team** (#66) β€”
multi-agent support for Claude Code, Kiro CLI, and Codex

#### Fixed
- **Add retention-days to security scan artifacts** (#64) β€” prevent
GitHub Actions storage quota exhaustion

#### Security
- Fixed 6 npm CVEs: handlebars, fast-xml-parser, minimatch, picomatch,
path-to-regexp, brace-expansion (#65)

## Test plan

- [x] Build passes (`npm run build`)
- [x] All 129 unit tests pass (`npm run test:ts`)
- [ ] CI checks pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant